🐛 Fix E3S1PRO DGUS builds #27211
Merged
🐛 Fix E3S1PRO DGUS builds #27211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While building configs with Marlin's
build_all_examplesscript, I found that E3S1PRO DGUS configs were now failing (MarlinFirmware/Configurations#1068) and tracked it down to PR #26261.Reverting the (unintentional?) change to
/dgus_e3s1pro/DGUSRxHandler.cppallows these configs to build again.Requirements
Any E3S1PRO DGUS-based config (
#define DGUS_LCD_UI E3S1PRO)Benefits
Allows E3S1PRO DGUS-based configs to build again.
Configurations
Any E3S1PRO DGUS config:
Related Issues