Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix E3S1PRO DGUS builds #27211

Conversation

thisiskeithb
Copy link
Member

Description

While building configs with Marlin's build_all_examples script, I found that E3S1PRO DGUS configs were now failing (MarlinFirmware/Configurations#1068) and tracked it down to PR #26261.

Reverting the (unintentional?) change to /dgus_e3s1pro/DGUSRxHandler.cpp allows these configs to build again.

Requirements

Any E3S1PRO DGUS-based config (#define DGUS_LCD_UI E3S1PRO)

Benefits

Allows E3S1PRO DGUS-based configs to build again.

Configurations

Any E3S1PRO DGUS config:

Related Issues

@thinkyhead thinkyhead merged commit e6a61b1 into MarlinFirmware:bugfix-2.1.x Jul 5, 2024
62 checks passed
@thisiskeithb thisiskeithb deleted the pr/fix_E3S1PRO_DGUS_builds branch July 5, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants